spv-wallet icon indicating copy to clipboard operation
spv-wallet copied to clipboard

feat(SPV-729) the rest filters

Open chris-4chain opened this issue 10 months ago • 2 comments

Pull Request Checklist

  • [x] 📖 I created my PR using provided : CODE_STANDARDS
  • [x] 📖 I have read the short Code of Conduct: CODE_OF_CONDUCT
  • [x] 🏠 I tested my changes locally.
  • [x] ✅ I have provided tests for my changes.
  • [x] 📝 I have used conventional commits.
  • [ ] 📗 I have updated any related documentation.
  • [x] 💾 PR was issued based on the Github or Jira issue.

chris-4chain avatar Apr 26 '24 12:04 chris-4chain

Manual Tests

:green_heart: Manual testing by @kuba-4chain resulted in success.

github-actions[bot] avatar Apr 26 '24 12:04 github-actions[bot]

Codecov Report

Attention: Patch coverage is 31.29771% with 180 lines in your changes are missing coverage. Please review.

Project coverage is 52.54%. Comparing base (14f361a) to head (342c0b2).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #569      +/-   ##
==========================================
+ Coverage   52.37%   52.54%   +0.16%     
==========================================
  Files         198      202       +4     
  Lines       11115    11191      +76     
==========================================
+ Hits         5822     5880      +58     
- Misses       4740     4755      +15     
- Partials      553      556       +3     
Flag Coverage Δ
unittests 52.54% <31.29%> (+0.16%) :arrow_up:

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
actions/contacts/models.go 0.00% <ø> (ø)
actions/destinations/count.go 0.00% <ø> (ø)
actions/destinations/search.go 0.00% <ø> (ø)
actions/transactions/count.go 0.00% <ø> (ø)
actions/transactions/search.go 0.00% <ø> (ø)
engine/action_access_key.go 0.00% <ø> (ø)
engine/action_contact.go 48.37% <100.00%> (ø)
engine/action_destination.go 54.83% <ø> (ø)
engine/action_draft_transaction.go 23.07% <ø> (ø)
engine/action_utxo.go 44.15% <ø> (ø)
... and 38 more

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 14f361a...342c0b2. Read the comment docs.

codecov-commenter avatar Apr 29 '24 06:04 codecov-commenter