spv-wallet
spv-wallet copied to clipboard
feat(BUX-754): PATCH endpoint for unconfirmed contact
Pull Request Checklist
- [x] π I created my PR using provided : CODE_STANDARDS
- [x] π I have read the short Code of Conduct: CODE_OF_CONDUCT
- [x] π I tested my changes locally.
- [ ] β I have provided tests for my changes.
- [x] π I have used conventional commits.
- [ ] π I have updated any related documentation.
- [x] πΎ PR was issued based on the Github or Jira issue.
Manual Tests
:green_heart: Manual testing by @javattor resulted in success.
Codecov Report
Attention: Patch coverage is 41.17647%
with 20 lines
in your changes are missing coverage. Please review.
Project coverage is 52.37%. Comparing base (
dfd7887
) to head (38a1080
).
Additional details and impacted files
@@ Coverage Diff @@
## main #552 +/- ##
==========================================
- Coverage 52.40% 52.37% -0.03%
==========================================
Files 197 198 +1
Lines 11081 11115 +34
==========================================
+ Hits 5807 5822 +15
- Misses 4724 4740 +16
- Partials 550 553 +3
Flag | Coverage Ξ | |
---|---|---|
unittests | 52.37% <41.17%> (-0.03%) |
:arrow_down: |
Flags with carried forward coverage won't be shown. Click here to find out more.
Files | Coverage Ξ | |
---|---|---|
actions/contacts/routes.go | 100.00% <100.00%> (ΓΈ) |
|
engine/model_contact.go | 70.19% <100.00%> (+1.02%) |
:arrow_up: |
engine/action_contact.go | 48.37% <57.14%> (+1.10%) |
:arrow_up: |
actions/contacts/unconfirm.go | 0.00% <0.00%> (ΓΈ) |
Continue to review full report in Codecov by Sentry.
Legend - Click here to learn more
Ξ = absolute <relative> (impact)
,ΓΈ = not affected
,? = missing data
Powered by Codecov. Last update dfd7887...38a1080. Read the comment docs.
testing