gui icon indicating copy to clipboard operation
gui copied to clipboard

Adds non-mempool wallet balance to overview

Open ajtowns opened this issue 1 month ago • 3 comments

The wallet can contain transactions that are not accepted into the node's mempool (eg due to containing a too large OP_RETURN output, due to too low a feerate, or due to too many unconfirmed ancestors). In the event you end up in this situation, it can appear as if funds have gone missing from your wallet due to the non-mempool balance not being reported. Correct this by reporting the non-mempool balance.

Depends on bitcoin/bitcoin#33671

ajtowns avatar Nov 19 '25 01:11 ajtowns

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.

Conflicts

Reviewers, this pull request conflicts with the following ones:

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot avatar Nov 19 '25 01:11 DrahtBot

To test, start with -datacarriersize=10, and run

send '{"data": "4368616e63656c6c6f72206f6e206272696e6b206f66207365636f6e64206261696c6f757420666f722062616e6b73"}' null "unset" 1

from the console. "Non-mempool: " should appear in the Balances pane on the Overview window with the change from the transaction. Restarting with -datacarriersize=100000 should allow the tx to enter the mempool, and move the amount into the Available balance. (Presumably, do this on -regtest after generating 100 blocks; or perhaps signet after grabbing some funds from a faucet)

ajtowns avatar Nov 19 '25 07:11 ajtowns

Screenshot:

non-mempool-gui

The negative sign for the non-memool stuff isn't really very clear, perhaps.

ajtowns avatar Nov 27 '25 08:11 ajtowns