gui icon indicating copy to clipboard operation
gui copied to clipboard

Published 20 hours ago • verified publisher icon bitcoin-core

getrawtransaction implementation

Open BrandonOdiwuor opened this issue 2 years ago • 9 comments

Fixes https://github.com/bitcoin-core/gui/issues/645.

Add getrawtransaction RPC to GUI on Tools -> Verify external txid. tab

Screencast from 21-12-2023 06:35:04 ASUBUHI.webm

BrandonOdiwuor avatar Nov 14 '23 11:11 BrandonOdiwuor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Reviews

See the guideline for information on the review process.

Type Reviewers
ACK pablomartin4btc, alfonsoromanz
Concept ACK hernanmarino, kristapsk, hebasto

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

Conflicts

No conflicts as of last run.

DrahtBot avatar Nov 14 '23 11:11 DrahtBot

Cool, that's pretty nice!

Just thinking out loud, but it does make me wonder if perhaps a new Verify or Utils button, in line with "Send | Recieve | Transactions" could be even nicer? If we added it there, we might consider adding a few more utils to the GUI like "Decode raw transaction", "Decode Script", "Get Descriptor Info", "Verify Message" etc. which folks who use the gui generally use other software for today...

willcl-ark avatar Nov 14 '23 11:11 willcl-ark

Cool, that's pretty nice!

Just thinking out loud, but it does make me wonder if perhaps a new Verify or Utils button, in line with "Send | Recieve | Transactions" could be even nicer? If we added it there, we might consider adding a few more utils to the GUI like "Decode raw transaction", "Decode Script", "Get Descriptor Info", "Verify Message" etc. which folks who use the gui generally use other software for today...

@willcl-ark would love to hear more opinions on this, I also think Help -> Verify external txid tab might not work well with adding more utils

BrandonOdiwuor avatar Nov 14 '23 14:11 BrandonOdiwuor

Yeah I don't want to derail this pr, which I think looks good on its own!

If there was desire to add more utils we could always move this later; I think this looks nice.

willcl-ark avatar Nov 14 '23 14:11 willcl-ark

I have updated the PR based on the feedback given above:

  • Added Tools menu
  • Moved getrawtransaction RPC implementation to Tools > verify external txid

cc: @willcl-ark @luke-jr @pablomartin4btc

BrandonOdiwuor avatar Dec 21 '23 03:12 BrandonOdiwuor

Concept ACK

kristapsk avatar Dec 28 '23 16:12 kristapsk

Concept ACK. However, I still agree with @promag's https://github.com/bitcoin/bitcoin/issues/19161#issuecomment-667726216:

GUI users can use the RPC console.

hebasto avatar Feb 12 '24 13:02 hebasto

Seems confusing to have the same feature present twice. Once in this pop-up and another time in the RPC pop-up?

If this is merged, then every RPC will be duplicated in a new GUI pop-up?

maflcko avatar Feb 13 '24 08:02 maflcko