gui
gui copied to clipboard
bitcoin-core
Update about logo icon (colour) to denote the chain type of the QT instance in About/ Help Message Window/ Dialog
It fixes https://github.com/bitcoin-core/gui/issues/761.
About logo icon is updated now with the correct colour indicating the chain type of the QT instance that user is running (as the splash screen), plus the title of the about window also is updated with the chain type string as in the main window.
Before PR changes screenshot
After PR changes screenshot
Current splash screen screenshot
(this hasn't been touched, just to show consistency with this PR changes)Tested it also with:
- mainnet (no command line args after
bitcoin-qtorbitcoin-qt -chain=main), -
-regtestand -
-testnet.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | BrandonOdiwuor |
| Concept ACK | hernanmarino |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
No conflicts as of last run.
It may help to show screenshots before and after
Thanks for your review @MarcoFalke, the before screenshot is on the issue #761 but I can bring it here if that makes it clearer.
It may help to show screenshots before and after
@maflcko I've updated the description with your suggestion (copied @furszy's style from his PR #764, I find it less invasive for the reviewer)
Not sure. All info displayed on the About page is fixed details about the software itself, not about the current (test)chain. So modulating the icon or title bar seems confusing, but no strong opinion.
Not sure. All info displayed on the About page is fixed details about the software itself, not about the current (test)chain.
In that case, shouldn't the logo on the About page be black-toned?
Not sure. All info displayed on the About page is fixed details about the software itself, not about the current (test)chain.
In that case, shouldn't the logo on the About page be black-toned?
I'm less sure about black-toned icons, in that specific case, it's more common usage I guess, users are already used to the orange one.
I think the most notable use case is when you have different instances open and you want to make sure you are standing on the correct one but more importantly the consistency regarding other components such as the splash screen and task-bar icons as pointed by @GBKS.