Showing Local Addresses in Node Window

Open jadijadi opened this issue 3 years ago • 20 comments

This change adds a new row to the Node Window (debugwindow.ui) under the Network section which shows the LocalAddresses.

fixes #564

Jun 29 '22 13:06 jadijadi

I've got this from the linter:

he locale dependent function std::to_string(...) appears to be used:
src/qt/rpcconsole.cpp:        localAddresses += item.first.ToString() + ":" + std::to_string(item.second.nPort) + ", ";

Unnecessary locale depedence can cause bugs that are very tricky to isolate and fix. Please avoid using locale dependent functions if possible.

Not sure how I should convert from int to string correctly. Any advice?

Jun 29 '22 14:06 jadijadi