gui icon indicating copy to clipboard operation
gui copied to clipboard

Add abitlity to resize peerTable and banTable

Open shaavan opened this issue 3 years ago • 9 comments

Till now, peerTable and banTable under the peerTab were fixed in height and cannot be resized. This creates unnecessary inconvenience, especially when you have many items on one table and not many on another.

This PR proposes to add a splitter between these two tables, allowing them to be resized freely.

Master PR
Screenshot from 2021-10-25 21-26-09 Screenshot from 2021-11-01 17-43-01

shaavan avatar Oct 25 '21 18:10 shaavan

concept ACK

I like the resize. Are they connected or active traffic?

Saibato avatar Oct 26 '21 17:10 Saibato

Are they connected or active traffic?

I think they both mean the same thing in this context. Connected peers, implies the peer that we are currently connected to, indicating the active traffic.

shaavan avatar Oct 27 '21 11:10 shaavan

Updated 5e54cfe to c09e6ad (pr457.01 -> pr457.02) Addressed @jarolrod comments

Updates:

  1. Considering that naming peerTable was not gathering a lot of support. I have removed that change from this PR.
  2. Made the peerTable and banTable non-collapsible.
  3. Increased splitter’s height from 3px to 4px.

This shouldn't display until there is a Banned Peers table

@jarolrod. As you rightly mentioned, showing splitter when no BanTable was looking kind of off. But in the new iteration of this PR, the splitter seems like an element of peerTable and looks aesthetically pleasing even when there is no banTable. I have updated the PR description with the new Screenshots. You can look at them to better get the feel of what I am trying to say.

shaavan avatar Nov 01 '21 12:11 shaavan

Updated from c09e6ad39da24a7a969533f6ce5c9cea14e8c9ce to aa6229e5d2bebe20d3e8e3eded8ff3ad7841bfcb (pr457.02 -> pr457.03, diff) Addressed @jarolrod comments

Changes:

  • Instead of hiding individual children of banTable. The code is now updated to hide the banTable widget. This will make sure the splitter will not be displayed when there is no banTable.
  • Updated sizePolicy to better reflect the peerWidget and the banTable widget.
  • Added code to save and restore the state (position) of the splitter. The state is remembered even in the case when GUI is shut down and restarted.

shaavan avatar Nov 03 '21 13:11 shaavan

cc @jarolrod. PR ready for another review!

shaavan avatar Nov 05 '21 03:11 shaavan

Concept ACK.

hebasto avatar Nov 21 '21 21:11 hebasto

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

  • #540 (network graph - show/hide panels based on window width/height by RandyMcMillan)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

DrahtBot avatar Dec 30 '21 10:12 DrahtBot

Updated from aa6229e5d2bebe20d3e8e3eded8ff3ad7841bfcb to 0c364201a2e16355cd6424c6137761c7967db4e0(pr457.04 -> pr457.05) Addressed @hebasto and @randymacmilan comments

  • Removed custom color of the added splitter
  • Moved childrenCollapsible=False to debugwindow.ui file.
  • Removed auto-generated changes by QtCreator.

shaavan avatar Jan 07 '22 18:01 shaavan

Updated from 0c364201a2e16355cd6424c6137761c7967db4e0 to 5a9bdce0ad753919522b8bc627c1c12d92d7cae8 (pr457.05 -> pr457.06, diff)

Addressed @hebasto comment

Changes:

  • Rebased PR over the current master.
  • Separated adding of banTable and tableSplitter in separate commits.
  • Removed unnecessary width/height changes.

shaavan avatar Jul 02 '22 13:07 shaavan

Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.

hebasto avatar Oct 26 '22 15:10 hebasto