gui
gui copied to clipboard
bitcoin-core
Bugfix: When restoring table columns, still set their minimum column width and stretch on last section
~~Regression introduced in #205~~
Correction: Undefined behaviour currently makes this a non-issue, but probably better to be safe and do it correctly.
When restoring table columns, still set their minimum column width and stretch on last section
Are minimumSectionSize and stretchLastSection parts of the saved state?
Regression introduced in #205
How is it observable by a user?
@luke-jr
The minimumSectionSize and stretchLastSection properties of the QHeaderView class are saved with QHeaderView::saveState and restored with QHeaderView::restoreState.
Regression introduced in #205
-
From the PR description it is not clear what is actually a bug in the current master branch. Could you elaborate please?
-
What is the reason to set
minimumSectionSizeandstretchLastSectionbefore restoring the header state, when during this restoring (if it succeeds, of course) the values of these properties will be overwritten?
I guess this is more about not relying on undefined behaviour rather than a bugfix.
Leaving the assignment prior to restoring sizes, so that users who actually go to the trouble to hack their setting are respected.
I guess this is more about not relying on undefined behaviour rather than a bugfix.
Leaving the assignment prior to restoring sizes, so that users who actually go to the trouble to hack their setting are respected.
Why only are setMinimumSectionSize and setStretchLastSection considered? And not setColumnWidth methods?
And -resetguisettings could always help :)
Let's leave this open - In previous work I added a "bumper" column to the tableview - this helped address some of the issues. The bumper column was an addon to other PRs but not a stand alone PR - I will put together a PR that focuses on why this is useful.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #684 (Improve 'Requested Payments History' Multiselect by john-moffett)
- #662 (Fix transaction view/table by luke-jr)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
