Peers window: Show direction in a new column, with clearer icon

[luke-jr]

Replaces the space-wasting "Inbound"/"Outbound" strings with left/right pointing to/from the address, and a tiny text label (which can be translated) overlayed.

[ghost]

Would be helpful to attach screenshot before/after code change.

[rebroad]

NACK - takes up more space - left and right don't obviously correspond to in or out, unless it's in the same column as something and then perhaps it would.

[jonatack]

The Direction column needs to be right before the Type column because Direction and Type are the two aspects of the current connection type naming, e.g. Outbound Full Relay, etc. It also should be "Inbound" or "Outbound" per the same naming. Another option is to drop the Type column completely, which I reckon is the wrong direction but the current state is confusing to users who have reported it as a bug.

[luke-jr]

@rebroad Left/right point away/toward the IP column. There's also the text part to avoid any uncertainty.

[shaavan]

@luke-jr, @hebasto. Just a reminder. One of the alternatives of this PR, #317, has been merged. So, can this PR be closed?

[luke-jr]

Rebased and description updated to current state of master

[hebasto]

Would be helpful to attach screenshot before/after code change.

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

Reviewers, this pull request conflicts with the following ones:

• #602 (Unify bitcoin-qt and bitcoind persistent settings by ryanofsky)
• #601 (refactor: Pass interfaces::Node references to OptionsModel constructor by ryanofsky)

If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

[hebasto]

Closing this as it has not had any activity in a while. If you are interested in continuing work on this, please leave a comment so that it can be reopened.