Intro: Have user choose assumevalid

[luke-jr]

Context: https://twitter.com/notgrubles/status/1297671475059728390

[Sjors]

Concept ACK on allowing the GUI user to opt-out of -assumevalid. The text needs some work, e.g. it should explain what is and isn't validated.

[luke-jr]

@Sjors Any suggestions for the text?

Note that validation is largely a black-and-white thing: unless you validate everything, you might as well be validating nothing. I think the only exception is the PoW?

[Sjors]

I'm pretty sure it also checks that coins aren't created out of nothing (i.e. it checks a coin spends outpoints and tracks which new ones it creates, and that the amounts add up).

[Rspigler]

Hm, I keep getting errors when trying to compile

make:

qt/intro.cpp: In constructor ‘Intro::Intro(QWidget*, int64_t, int64_t)’: qt/intro.cpp:178:52: error: invalid initialization of reference of type ‘const string&’ {aka ‘const std::__cxx11::basic_string&’} from expression of type ‘ArgsManager’ const auto chainparams = CreateChainParams(gArgs, gArgs.GetChainName()); ^~~~~ In file included from qt/intro.cpp:9: ./chainparams.h:117:37: note: in passing argument 1 of ‘std::unique_ptr<const CChainParams> CreateChainParams(const string&)’ std::unique_ptr<const CChainParams> CreateChainParams(const std::string& chain); ^~~~~~~~~~~~~~~~~ make[2]: *** [Makefile:13191: qt/libbitcoinqt_a-intro.o] Error 1 make[2]: Leaving directory '/home/user/gui/src' make[1]: *** [Makefile:18989: all-recursive] Error 1 make[1]: Leaving directory '/home/user/gui/src' make: *** [Makefile:798: all-recursive] Error 1

[Rspigler]

~~Still getting errors trying to compile~~ Duh

[luke-jr]

Rebased, reviews addressed

[Talkless]

Sorry for a lot of "n/a's" @luke-jr , I guess I need to up my diff reading game...

[DrahtBot]

🐙 This pull request conflicts with the target branch and needs rebase.

_{Want to unsubscribe from rebase notifications on this pull request? Just convert this pull request to a "draft".}

[Rspigler]

tACK 75aff9e0ff7f98a5ec64d18641a9654ab5b09cdc Simple, I like the language, and I think it is an important setting the user should set

[laanwj]

Concept ACK, this choice seems sufficiently important to me to expose in the GUI.

[luke-jr]

Rebased

[DrahtBot]

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Conflicts

No conflicts as of last run.