gui
gui copied to clipboard
bitcoin-core
Replace send-to-self with dual send+receive entries
Makes the GUI transaction list more like the RPC, and IMO clearer in general.
As a side effect, this also fixes the GUI entries when a transaction is a net profit to us, but some inputs were also from us.
Originally https://github.com/bitcoin/bitcoin/pull/15115
Has Concept ACKs from @Empact @jonasschnelli
@luke-jr what's the difference between raising a pull on this repository vs the bitcoin repository (as per your original 15115 pull request)? Sorry to ask this here but I'm unsure of where best to ask this.
@rebroad
@luke-jr what's the difference between raising a pull on this repository vs the bitcoin repository (as per your original 15115 pull request)? Sorry to ask this here but I'm unsure of where best to ask this.
Moving into the GUI repo was requested explicitly by @fanquake.
Getting:
terminate called after throwing an instance of 'std::runtime_error' what(): JSON value is not a string as expected Aborted
when trying to open bitcoin-qt after compiling 2bb4e30.
Edit: I'm getting this on master too
ACK 2bb4e3076342162cab9b359e020c7f189db9d399
Tested that it does indeed split up send-to-self payments.
@luke-jr Are you planning to address https://github.com/bitcoin-core/gui/pull/119#pullrequestreview-1157914417?
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Reviews
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | achow101 |
| Concept ACK | Rspigler |
| Stale ACK | promag |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
