gui-qml icon indicating copy to clipboard operation
gui-qml copied to clipboard

Bugfix custom datadir doubleClick - Follow-up #392

Open pablomartin4btc opened this issue 10 months ago • 11 comments

This is a desktop-only (not mobile/ android) workaround to disable double-click on custom datadir which is on the StorageLocations.qml componennt.

Double-clicking was causing the file dialog to get open but losing focus and moving to the background, bringing upfront the main window which was useless because the file dialog is modal (issue raised originally by @MarnixCroes on PR #392 but still persists in ongoing PR #397).

pablomartin4btc avatar Apr 15 '24 02:04 pablomartin4btc

thanks for picking this up. it doesn't fully fix the problem. I can still repro sometimes, like +- 1 out of 10 times. (double-checked I'm not making an error, like accidentally having the second click change the focus.)

Ok, thanks for testing it promptly. I couldn't reproduce the issue on Ubuntu, are you on Mac?

If we can't fully fix it, I'd need to investigate another approach and close this one.

pablomartin4btc avatar Apr 15 '24 14:04 pablomartin4btc

are you on Mac?

no, Ubuntu 22.04.4 LTS

MarnixCroes avatar Apr 15 '24 15:04 MarnixCroes

@MarnixCroes perhaps it has to do with the OS double click (speed?) config, could you please try changing timer interval from 50 to 150 or 300? Thanks!

pablomartin4btc avatar Apr 15 '24 15:04 pablomartin4btc

@MarnixCroes perhaps it has to do with the OS double click (speed?) config, could you please try changing timer interval from 50 to 150 or 300? Thanks!

I could repro with 150. (happened after 25 tries) I could repro with 300, only after +- 100 tries

MarnixCroes avatar Apr 22 '24 16:04 MarnixCroes

I could repro with 150. (happened after 25 tries) I could repro with 300, only after +- 100 tries

Thanks for testing it again, let's discuss it tomorrow with the rest of the team on the devs call, so far we can have this as a workaround to solve this bug until we find a better approach.

pablomartin4btc avatar Apr 23 '24 02:04 pablomartin4btc

Updates:

pablomartin4btc avatar May 01 '24 21:05 pablomartin4btc

Updates:

pablomartin4btc avatar May 04 '24 05:05 pablomartin4btc

Rebased to refresh CIs (#402). No code changes.

pablomartin4btc avatar May 27 '24 15:05 pablomartin4btc

Please rebase to resolve conflicts.

hebasto avatar Aug 12 '24 10:08 hebasto

Rebased as requested. No code changes.

pablomartin4btc avatar Aug 12 '24 15:08 pablomartin4btc

Updates:

  • Forgot to update the interval as per @MarnixCroes previous tests results.

pablomartin4btc avatar Aug 31 '24 15:08 pablomartin4btc