gui-qml icon indicating copy to clipboard operation
gui-qml copied to clipboard

Ellipsify the version number on the about screen

Open GBKS opened this issue 1 year ago • 3 comments

Issues, reports or feature requests related to the GUI should be opened directly on the GUI repo

  • [X] I still think this issue should be opened here

Report

The version number overlaps with the label. On tablet, the row item expands beyond its container boundaries on the right. See screenshots.

image

We could ellipse this number. If it is important to show the whole thing, maybe consider using a vertical layout (value text below the label text).

Since this links to a website, the icon should also be the link icon used for the website and source code links further up on the screen.

I am also curious as to what version this refers to. Aren't version usually just regular numbers, like Bitcoin Core 26?

GBKS avatar Dec 07 '23 13:12 GBKS

@GBKS is this still an issue? (on mobile/ tablet)

I see it correctly in the desktop version at the moment:

image

pablomartin4btc avatar May 06 '24 18:05 pablomartin4btc

I don't believe this is an issue anymore with updates that were done to all the elements here.

@GBKS the version you're seeing there contains what top commit the version of the GUI you're using was built with. This has always been done for user-done builds in the case that an issue arises, this commit hash shows where the user built at. Proper releases only have the Core version number without the commit hash (v28.0)

jarolrod avatar Sep 25 '24 11:09 jarolrod

Is it resolved by just having shorter strings or by automatically eliding ("...") text (which is the more robust solution)? Seems like QML supports this.

GBKS avatar Sep 26 '24 08:09 GBKS