bitcoincore.org
bitcoincore.org copied to clipboard
bitcoin-core
Remove redundant and outdated authors sidebar
This affects the following pages:
- https://bitcoincore.org/en/2015/12/14/segregated-witness/
- https://bitcoincore.org/en/blog/2016/04/14/maintainer/
- https://bitcoincore.org/zh_CN/2016/02/26/zero-knowledge-contingent-payments-announcement/
All three pages already include the author information in the text, thus the authors sidebar is redundant.
Also, the links might be outdated. For example https://twitter.com/orionwl returns This account doesn’t exist.
Instead of maintaining the sidebar links, remove them as they are redundant.
For reference, if this gets merged and someone wonders how the site looked like before the changes. An example:
looks like not a bad idea
On Mon, Feb 14, 2022 at 12:00 PM MacroFake @.***> wrote:
This affects the following pages:
- https://bitcoincore.org/en/2015/12/14/segregated-witness/
- https://bitcoincore.org/en/blog/2016/04/14/maintainer/
https://bitcoincore.org/zh_CN/2016/02/26/zero-knowledge-contingent-payments-announcement/
All three pages already include the author information in the test, thus the authors sidebar is redundant.
Also, the links might be outdated. For example https://twitter.com/orionwl returns This account doesn’t exist.
Instead of maintaining the sidebar links, remove them as they are redundant.
You can view, comment on, or merge this pull request online at:
https://github.com/bitcoin-core/bitcoincore.org/pull/863 Commit Summary
- b1ed276 https://github.com/bitcoin-core/bitcoincore.org/pull/863/commits/b1ed276d434393bd020d6fa23e4f72e55c85c6ef Remove redundant and outdated authors sidebar
File Changes
(11 files https://github.com/bitcoin-core/bitcoincore.org/pull/863/files )
- D _data/authors.yml https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-fdca1c48b249c38bee14489176341e078b9cfcf168e19ba1c669b92fa7322c49 (20)
- D _includes/author-bio.html https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-81fdade7f6c354430486244df09a7e043189e3b5922cefeca6b6e84f86679bfd (25)
- M _layouts/home.html https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-e73b35364c60ba845bb11a95b54e7b8e0439b5aafc61723021cd0ea7b56a709c (3)
- M _layouts/page.html https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-f3bc278cee76b92ca1a167ac8eaeec0c431591ea6bc19a46e34a9afecec949fc (3)
- M _layouts/post-index.html https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-e4392d8fc2413fca80d3562af726c6f54767916e1e147b1a2a0283b310ef1723 (3)
- M _layouts/post.html https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-88e83e5d0edb4286d0e35534fa9f49405a4ef6724137b468772a31183cb43a3f (3)
- M _posts/en/posts/2015-12-14-segregated-witness.md https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-762e6b9ed99cbc93991726126490ae145bec29eed701234229eade53ece8e059 (1)
- M _posts/en/posts/2016-02-26-zkcp.md https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-e54f6725d3bc6c6e7c59297a8b6a0eb5ef66664a5c771fdc5e726d69376ee1bc (1)
- M _posts/en/posts/2016-04-14-maintainer-appointed-marcofalke.md https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-fce51519aea3e62b046d6ab396db048f35f2f95f290f8b93aee9d4eebf927e2c (1)
- M _posts/zh_CN/posts/2016-02-26-zkcp.md https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-15fe434e88bb0329e314c04955bdd2f35705970f9256e224d518270c7f86c625 (1)
- D assets/images/bio-photo.jpg https://github.com/bitcoin-core/bitcoincore.org/pull/863/files#diff-3e02c78d3b9b8c57a07f52293036ce37b0ea767d55dec58ceb44657bdbc85818 (0)
Patch Links:
- https://github.com/bitcoin-core/bitcoincore.org/pull/863.patch
- https://github.com/bitcoin-core/bitcoincore.org/pull/863.diff
— Reply to this email directly, view it on GitHub https://github.com/bitcoin-core/bitcoincore.org/pull/863, or unsubscribe https://github.com/notifications/unsubscribe-auth/AMRS4W5FTT7ZUHI4Q2J4CHDU3DOE5ANCNFSM5OLCLIDQ . Triage notifications on the go with GitHub Mobile for iOS https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675 or Android https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub.
You are receiving this because you are subscribed to this thread.Message ID: @.***>
Burninate related styles?
https://github.com/bitcoin-core/bitcoincore.org/blob/853d3d56db7f3d4981de0af30c85b078bb032a82/_sass/page.scss#L594-L661
Haven't tested that, dunno if breaks anything.
Maybe removing styles breaks the /doc/ layout. But is the author sidebar really informative in the /doc/ layout?
If it just tells "Documentation exported from Bitcoin Core 0.18.0" that's arguably needed there.
Even so, the style can be burninated partially by removing some classes such as bio-photo, I guess.
Sure, happy to remove more stuff, but I'd prefer to do in small steps to not overexert reviewers
Sure, happy to remove more stuff, but I'd prefer to do in small steps to not overexert reviewers
That's good, but removing class bio-photo from scss is part of this PR, more than the next one.
It seems like this PR broke the site layout. On 3b17b95:
On the previous head 0f62ce0:
I can't render the website locally, but maybe re-adding an empty <div class="article-author-side"></div> in the four places where I removed it fixes it?
but maybe re-adding an empty
<div class="article-author-side"></div>in the four places where I removed it fixes it?
I tried that initially but didn't work. Adding   did the trick, however. Fixed in https://github.com/bitcoin-core/bitcoincore.org/pull/938.