HWI icon indicating copy to clipboard operation
HWI copied to clipboard

ColdCard: test_signtx broken

Open Sjors opened this issue 5 months ago • 5 comments

test_signtx has been temporarily disabled by #795. It failed with:

ERROR: coldcard: test_signtx (test_device.TestSignTx.test_signtx) (addrtypes=['legacy'], multisig_types=['legacy'], external=True, op_return=False)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/__w/HWI/HWI/test/test_device.py", line 588, in test_signtx
    self._test_signtx(addrtypes, multisig_types, external, op_return)
  File "/__w/HWI/HWI/test/test_device.py", line 576, in _test_signtx
    self._generate_and_finalize(True, psbt)
  File "/__w/HWI/HWI/test/test_device.py", line 403, in _generate_and_finalize
    self.assertTrue(first_sign_res["signed"])
                    ~~~~~~~~~~~~~~^^^^^^^^^^
KeyError: 'signed'

Sjors avatar Jul 24 '25 07:07 Sjors

cc @brunoerg

Sjors avatar Jul 24 '25 07:07 Sjors

I'm taking a look at it.

brunoerg avatar Jul 24 '25 14:07 brunoerg

As far as I could debug, it seems an issue on the multisig wallet: {'error': 'Coldcard Error: Unknown multisig wallet', 'code': -7}

brunoerg avatar Jul 29 '25 13:07 brunoerg

test_big_tx is broken here as well.

======================================================================
FAIL: coldcard: test_big_tx (test_device.TestSignTx)
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/Users/brunogarcia/projects/HWI/test/test_device.py", line 610, in test_big_tx
    self.fail('Big tx did not cause CLI to error')
AssertionError: Big tx did not cause CLI to error

brunoerg avatar Jul 29 '25 13:07 brunoerg

test_big_tx is broken here as well.

Indeed I disabled them both in #795

Sjors avatar Jul 29 '25 14:07 Sjors