Don't enumerate emulators unless `--emulator` flag is provided

[prusnak]

See https://github.com/bitcoin-core/HWI/issues/652#issuecomment-1340149342 for motivation.

And https://github.com/bitcoin-core/HWI/issues/628.

I think there are other issues reported here which are caused by stalled enumerations where there is something else than an emulator running on a scanned port.

[craigraw]

+1 on this - it's a common problem that is often time-consuming to diagnose.

[achow101]

Since that would be a breaking change to the interface, would it be acceptable to do the inverse - a --no-emulators option to explicitly ignore emulators?

[craigraw]

Yes, that would work for me.

[prusnak]

Since emulators are only used by developers and not regular users, I would be OK with changing the default. It would be also the most straightforward way how to fix weird issues easily in the whole ecosystem.

However, if you feel strongly about not changing it, I am fine with the --no-emulators option. But we would need to reach out to all downstream projects (wallets that use HWI), to add the option into their stack.

[achow101]

Mainly I don't want to change the default behavior since SemVer (which I'm trying to follow) requires bumping the major version for that.

[prusnak]

Mainly I don't want to change the default behavior since SemVer (which I'm trying to follow) requires bumping the major version for that.

So why not bump the major version then?

[achow101]

So why not bump the major version then?

I suppose I could. Just feels weird to do that when there's nothing else going on.

[prusnak]

I suppose I could. Just feels weird to do that when there's nothing else going on.

Yes. That is SemVer - lots of mixed feelings :-)