PNGenc icon indicating copy to clipboard operation
PNGenc copied to clipboard

Published 20 hours ago • verified publisher icon bitbank2

Corruption with addLine but not addRGB565Line

Open prplz opened this issue 1 year ago • 3 comments

I was experiencing corruption of the png when using addLine, but not when using addRGB565Line. I noticed they don't share code and they aren't identical, and copying the "good" code from add565 fixed the issue for me even though I didn't look into what the actual changes are: bd26d990769a3eb213e5bb9d1b68c1c52f242796.

prplz avatar Jan 25 '24 10:01 prplz

Thanks for finding this. I'm super busy on a bunch of other projects. Can you do a pull request?

bitbank2 avatar Jan 25 '24 11:01 bitbank2

Sure! Is it ok if I also make addRGB565Line tail call into addLine to deduplicate the code?

prplz avatar Jan 26 '24 00:01 prplz

certainly - thanks :)

bitbank2 avatar Jan 26 '24 08:01 bitbank2