adrenaline icon indicating copy to clipboard operation
adrenaline copied to clipboard

Adrenaline::__invoke() not compatible with Adroit::__invoke()

Open shochdoerfer opened this issue 8 years ago • 4 comments

As it turns out the current implementation of Adrenaline::__invoke() is not compatible with Adroit::__invoke() as the latter does return the Response and Adrenaline does not. How do we want to address this issue?

shochdoerfer avatar Feb 11 '17 11:02 shochdoerfer

Currently Adrenaline inherits from Adroit which imho is not the best approach. Instead I would prefer Adrenaline to make use of Adroit but I couldn't figure out why It didn't work. Maybe it is possible right now due to the Stratigility upgrade and if that worked it would also solve the problem this issue addresses. So would you mind opening an issue for that? Of course it has to be changed but I don't want Adrenaline to return the response since it is a framework which emits the response whilst Adroit is a middleware.

dropdevcoding avatar Feb 12 '17 21:02 dropdevcoding

@dropdevcoding why opening another issue? Isn't this sufficient? ;) Mind working on a proposal for a change?

shochdoerfer avatar Feb 12 '17 23:02 shochdoerfer

You're right, sufficient enough. I'd like to work on a PR but unfortunately I won't find the time to before thursday. If that is ok for you, I'll try to propose a solution until friday / saturday

dropdevcoding avatar Feb 13 '17 20:02 dropdevcoding

Sure not a problem at all. Thanks for taking care of the issue!

shochdoerfer avatar Feb 14 '17 09:02 shochdoerfer