backintime icon indicating copy to clipboard operation
backintime copied to clipboard

Remove "class DriveInfo" (dead code)

Open buhtz opened this issue 1 year ago • 1 comments

Always surfing through the codebase ... 🏄

The class DriveInfo was introduced in 2009 by Dan. https://github.com/bit-team/backintime/blob/5aa0746bf36bb49d95969e558ca4fdde38dfaa86/common/driveinfo.py#L25

Looking into the commit history it wasn't substantially modified. But it was also never used (checked via git grep).

Code and idea behind should be investigated. There is not much documentation about it.

buhtz avatar Apr 23 '24 14:04 buhtz

The class try to find out the features (permissions, hardlinks, ...) of the given file system. And it seems to store the result as a config file.

I say it can be removed without replacement.

buhtz avatar Apr 24 '24 09:04 buhtz

Hello @buhtz , Can I help the team out and perform this code modification ?

Let me know if you need any more information

SanjaySiddharth avatar May 01 '24 16:05 SanjaySiddharth

Dear SanjaySiddharth , thanks for this kind offer. When scrolling up you might see that the issue was referenced in #1706 which itself is a Pull Request. So the Issue was taken by some one else and has a solution (#1706).

Let me know if you find something else.

Best, Christian

buhtz avatar May 01 '24 17:05 buhtz

Hey @buhtz ,

Thanks for taking the time to let me know this.

Regards, Sanjay

SanjaySiddharth avatar May 01 '24 17:05 SanjaySiddharth