backintime icon indicating copy to clipboard operation
backintime copied to clipboard

Replace an "isIPv6Address()" with python package "ipaddress"

Open buhtz opened this issue 10 months ago • 3 comments

Replace this method isIPv6Address() with Python in-build ipaddress package introduce with Python 3.3.

https://github.com/bit-team/backintime/blob/d33f35e10b4c3027b3b12881152c157eb1b2cc8c/common/tools.py#L1849

This is the only place this function is used. Remove the code and its unit tests.

buhtz avatar Apr 13 '24 20:04 buhtz

@buhtz I would like to work on this, if it's still available.

jarbhav avatar Apr 14 '24 13:04 jarbhav

Hello Vaibhav, OK, you are in. Thanks for you offer.

Best, Christian

buhtz avatar Apr 14 '24 17:04 buhtz

Hi Christian, I have opened PR #1689 addressing this, please let me know if any changes are needed.

Thanks, Vaibhav

jarbhav avatar Apr 15 '24 07:04 jarbhav