Every launch file needs a sim parameter

[jaagut]

In total, we currently have 105 launch files of which 42 contain the sim argument.

The following launch files do not contain the sim launch argument. Please review them and create a PR to fix them if necessary (link PR here):

• [x] ./udp_bridge/launch/send.launch
• [x] ./udp_bridge/launch/receive.launch
• [x] ./udp_bridge/test/rostests/test_sender_receiver.launch
• [x] ./udp_bridge/test/rostests/test_sender.launch
• [x] ./bitbots_lowlevel/bitbots_ros_control/launch/viz_imu.launch
• [x] ./bitbots_lowlevel/bitbots_ros_control/launch/rviz_interactive_imu.launch
• [ ] ./bitbots_lowlevel/bitbots_ros_control/launch/pressure_converter.launch
• [x] ./bitbots_lowlevel/bitbots_ros_control/launch/viz_pressure.launch
• [x] ./bitbots_lowlevel/bitbots_ros_control/launch/viz_servos.launch
• [ ] ./bitbots_lowlevel/bitbots_buttons/launch/buttons.launch
• [ ] ./wolfgang_robot/wolfgang_pybullet_sim/launch/simulation.launch
• [x] ./wolfgang_robot/wolfgang_moveit_config/launch/moveit_rviz.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/gazebo.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/warehouse.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/demo_gazebo.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/setup_assistant.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/ros_controllers.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/demo.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/planning_context.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/run_benchmark_ompl.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/joystick_control.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/move_group.launch
• [ ] ./wolfgang_robot/wolfgang_moveit_config/launch/default_warehouse_db.launch
• [x] ./wolfgang_robot/wolfgang_description/launch/rviz.launch
• [ ] ./wolfgang_robot/wolfgang_description/launch/standalone.launch
• [x] ./wolfgang_robot/wolfgang_robocup_api/launch/wolfgang_robocup_api_bridge.launch
• [x] ./wolfgang_robot/wolfgang_robocup_api/launch/robocup_teamplayer.launch
• [x] ./wolfgang_robot/wolfgang_robocup_api/launch/record_bag.launch
• [x] ./wolfgang_robot/wolfgang_robocup_api/launch/robocup_walk.launch
• [x] ./wolfgang_robot/wolfgang_webots_sim/launch/fake_localization.launch
• [x] ./wolfgang_robot/wolfgang_webots_sim/launch/simulation.launch
• [x] ./wolfgang_robot/wolfgang_webots_sim/launch/single_robot_controller.launch
• [ ] ./bitbots_motion/bitbots_dynup/test/rostests/test_dynup_runs.launch
• [ ] ./bitbots_motion/bitbots_dynamic_kick/test/rostests/test_kick_runs.launch
• [ ] ./bitbots_motion/bitbots_dynamic_kick/launch/viz.launch
• [ ] ./bitbots_motion/bitbots_quintic_walk/test/rostests/test_walk_runs.launch
• [ ] ./bitbots_motion/bitbots_quintic_walk/test/rostests/test_walk.launch
• [ ] ./bitbots_navigation/bitbots_localization/launch/transforms.launch
• [ ] ./bitbots_navigation/bitbots_localization/launch/test.launch
• [ ] ./bitbots_misc/bitbots_teleop/launch/robot_teleop.launch
• [ ] ./bitbots_misc/system_monitor/launch/system_monitor.launch
• [ ] ./bitbots_misc/system_monitor/launch/viz.launch
• [ ] ./bitbots_misc/bitbots_bringup/launch/game_start.launch
• [ ] ./bitbots_misc/bitbots_bringup/launch/visualization.launch
• [ ] ./bitbots_misc/bitbots_bringup/launch/rviz_multirobot.launch
• [x] ./bitbots_misc/bitbots_bringup/launch/gazebo.launch
• [x] ./bitbots_misc/bitbots_bringup/launch/simulator_teamplayer.launch
• [x] ./bitbots_misc/bitbots_ceiling_cam/launch/ceiling_cam.launch
• [x] ./bitbots_misc/bitbots_basler_camera/launch/basler_camera.launch
• [ ] ./bitbots_misc/bitbots_utils/launch/tools.launch
• [x] ./lib/hlvs_player/launch/example.launch
• [ ] ./humanoid_league_misc/humanoid_league_speaker/launch/speaker.launch
• [ ] ./humanoid_league_misc/humanoid_league_team_communication/launch/team_comm_test_marker.launch
• [ ] ./bitbots_tools/bitbots_test/test/rostests/test_mock_subscriber.launch
• [x] ./bitbots_tools/bitbots_test/test/rostests/test_webots_simulator.launch
• [ ] ./bitbots_tools/bitbots_test/test/rostests/test_assertions.launch
• [ ] ./humanoid_league_visualization/humanoid_league_interactive_marker/launch/test.launch
• [ ] ./humanoid_league_visualization/humanoid_league_interactive_marker/launch/interactive_marker.launch
• [ ] ./bitbots_vision/bitbots_vision/launch/record_bag.launch
• [ ] ./bitbots_behavior/bitbots_body_behavior/launch/behavior_standalone.launch
• [ ] ./bitbots_behavior/bitbots_body_behavior/launch/simple_behavior.launch
• [ ] ./bitbots_behavior/bitbots_body_behavior/test/rostests/test_dsd_file.launch
• [ ] ./bitbots_behavior/bitbots_head_behavior/launch/head_behavior_standalone.launch

[jaagut]

@bit-bots/developer Please evaluate these files and check the mark, if already handled

[Flova]

I have checked all ones which were fine without a sim param at first sight. This is mainly the case for sim related launch files that run only in simulation and therefore do not include this param. Also, launch files for viz tests are unlikely to run in a sim environment. Similarly, things like the ceiling cam or basler camera are only needed on the real robot.

We could still check all sim launch files, if the use_sim_time parameter is set for all nodes even if they don't have a sim argument themselves.