bisq2 icon indicating copy to clipboard operation
bisq2 copied to clipboard

Published 20 hours ago • verified publisher icon bisq-network

Finish implementation for input validators

Open HenrikJannsen opened this issue 1 year ago • 7 comments

Input validators are implemented but missing the handling in the UI components to show the error messages and adopt the css. It should follow the pattern used in JavaFX components/JFoenix.

HenrikJannsen avatar May 26 '23 13:05 HenrikJannsen

taking a look at this one

namloan avatar Aug 12 '23 11:08 namloan

been offline for a week, I'm retaking this today.

namloan avatar Aug 24 '23 16:08 namloan

@namloan Are there still some open? Maybe can can add a bullet point list of the UI screens where validation is open and set priorities to each?

HenrikJannsen avatar Nov 11 '23 02:11 HenrikJannsen

@HenrikJannsen we're still missing some validations in 'User options':

  • Reputation. I started working on this but halted it until https://github.com/bisq-network/bisq2/pull/1320/ is merged as there will be conflicts. Validating the numbers are >= 0 and that the score isn't calculated when amounts are invalid.
  • Bonded roles. Not sure what validations we want here but maybe at least text length size.
  • Nodes. Same as above.

namloan avatar Nov 11 '23 05:11 namloan

We can consider the Pro user/contributor sections as lower prio. Feel free to pause that task and pick anything else with higher prio if you like. I changed milestone to reflect that remaining part is not high prio.

HenrikJannsen avatar Nov 13 '23 07:11 HenrikJannsen