follow established conventions for Tor integration

[adrelanos]

Bisq seems to take quite a unique approach to Tor integration, not following any established conventions. Therefore making things difficult down the line and incompatible with Tor based operating systems such as Whonix and perhaps Tails.

issues:

• It is currently not possible to use Bisq with an already installed system Tor?
• Bisq cannot be with a Tor that is already running on a different computer (or virtual machine)?
• https://github.com/bisq-network/bisq2/issues/1894

old issues fixed in git:

• Bisq even used to parse Tor's log file. Just mentioning this to show that invented solutions without looking at the exiting conventions and talking to the Tor community, complex things will be implemented, incompatible, causing later issues, requiring refactoring.

Notes:

• Tor over Tor should be prevented. (reasons: adversarial for anonymity, bad for performance, see Refrain from "Tor over Tor" Scenarios)

What are the conventions? See:

• Tor: https://gitlab.torproject.org/legacy/trac/-/wikis/doc/Tor_friendly_applications_best_practices
• Whonix: https://www.whonix.org/wiki/Dev/Project_friendly_applications_best_practices

Full disclosure: I am a developer of Whonix.