bisq2 icon indicating copy to clipboard operation
bisq2 copied to clipboard

Disabling `Use animations` setting needs to ensure no animations/transitions are used

Open devinbileck opened this issue 11 months ago • 2 comments

Summary

As discovered in #1857, if hardware acceleration is not enabled then the UI may suffer from poor performance.

If not automatically detected, hardware acceleration can be force enabled with -Dprism.forceGPU=true. However, this will not be a viable workaround for systems that do not have hardware acceleration such as virtual machines.

As I discovered while investigating #1857, commenting out various animations such as timeline.play() improved the performance.

Currently disabling Use animations under Settings > Display settings does not help. Disabling this needs to ensure no animations/transitions are used at all. Optionally, the app could detect whether hardware acceleration is in use and disable the Use animations setting automatically.

Acceptance Criteria

  • All animations/transitions used throughout the UI are inactive when the Use animations setting is disabled.

devinbileck avatar Mar 20 '24 18:03 devinbileck

It should be deactivated everywhere if the use animations flag in the preferences is turned off. Have you tried that and found still some animations? Might have been forgotten to check at some animations.

HenrikJannsen avatar Aug 18 '24 09:08 HenrikJannsen

It should be deactivated everywhere if the use animations flag in the preferences is turned off. Have you tried that and found still some animations? Might have been forgotten to check at some animations.

No, I did not do any further investigation to find specific animations. If someone has some time, would be good to revisit and investigate this.

devinbileck avatar Aug 20 '24 05:08 devinbileck