bisq2 icon indicating copy to clipboard operation
bisq2 copied to clipboard

Improve completed screen at the trade process

Open HenrikJannsen opened this issue 1 year ago • 8 comments

The completed screen could need more love...

HenrikJannsen avatar Sep 16 '23 18:09 HenrikJannsen

Following up with my last PR (on the Bisq Easy waiting states icons), I think I can work on this.

axpoems avatar Oct 01 '23 14:10 axpoems

See discussion at https://github.com/bisq-network/bisq2/pull/1349#issuecomment-1804920684

HenrikJannsen avatar Nov 10 '23 01:11 HenrikJannsen

From discussion at #1349

I've created these mock-ups for the final step of the trade process for both seller and buyer.

For the seller:

mock 2 seller

For the buyer:

mock 2 buyer

@HenrikJannsen What do you think? Is there any parameter that is missing or in excess in the panels?

axpoems avatar Dec 12 '23 23:12 axpoems

Looks great! Is it intended to be shown only on the right side or over the whole available width (hiding the left stepper box)?

HenrikJannsen avatar Dec 13 '23 07:12 HenrikJannsen

Looks great! Is it intended to be shown only on the right side or over the whole available width (hiding the left stepper box)?

The idea is the latter.

axpoems avatar Dec 13 '23 11:12 axpoems

Is there any parameter that is missing or in excess in the panels?

Maybe instead the fees we could show how long the trade took? Or show the real amount of the minerfee (we could get that from the tx - but could be done later).

We would like to add a feedback feature. Only to the peer as we dont know how to do that decentralized/secure. But I think it would be still nice to have the option to send and receive feedback from the peer (some simple with stars and a text msg and maybe some emoticons). But can be delegated for later as well.

HenrikJannsen avatar Dec 15 '23 02:12 HenrikJannsen

Maybe instead the fees we could show how long the trade took?

Yes that could be included. Why do you think this is important?


Or show the real amount of the minerfee (we could get that from the tx - but could be done later).

You mean in the buyer? I thought the buyer wouldn't care for a fee that he didn't pay, but could be included as well.


We would like to add a feedback feature. Only to the peer as we dont know how to do that decentralized/secure. But I think it would be still nice to have the option to send and receive feedback from the peer (some simple with stars and a text msg and maybe some emoticons). But can be delegated for later as well.

To the peer do you mean to the buyer? I like this idea; however, implementing the feedback feature would require a redesign of the screen. My suggestion is to include a 'send feedback' button. Clicking on this button would lead the user to a new screen where, as you suggested, he can rate with stars and include a brief text message.

axpoems avatar Dec 16 '23 14:12 axpoems

Why do you think this is important?

I think the trade duration is an important factor, but not sure how important. To keep all to the minimum is maybe better. We should avoid information overload.

You mean in the buyer? I thought the buyer wouldn't care for a fee that he didn't pay, but could be included as well.

For both, but true for the buyer its less important and the seller will know it anyway. Again maybe better to keep all to the minimum.

To the peer do you mean to the buyer?

Both sides. Yes was meant as button which shows a new screen/popup for giving feedback. But I think that can be delegated for post-launch.

HenrikJannsen avatar Dec 17 '23 15:12 HenrikJannsen