bisq icon indicating copy to clipboard operation
bisq copied to clipboard

Published 20 hours ago • verified publisher icon bisq-network

Add API for payment started with XMR auto conf params

Open jmacxx opened this issue 1 year ago • 1 comments

Fixes #7033

Basedon / follow-on from #7023.

Allows tx-id & tx-key to be specified for XMR auto-confirm.

jmacxx avatar Feb 14 '24 04:02 jmacxx

It works great, thank you!

dutu avatar Feb 15 '24 15:02 dutu

@jmacxx are we not going to have this change implemented?

dutu avatar Feb 26 '24 14:02 dutu

I had to fix merge conflicts with the current master branch. Also, I don't know how to implement @alvasw suggestion above.

ghost avatar Feb 26 '24 14:02 ghost

From what I can see, you have implemented null and isEmpty checks in line with existing code done for other parameters.

@alvasw, for consistency sake would it make more sense to change these checks based on your suggestions separately, when it's done for all parameters?

dutu avatar Feb 26 '24 14:02 dutu