bisq
bisq copied to clipboard
bisq-network
Fix clickable area of Enable Offers toggle button
Thanks for opening this pull request!
Please check out our contributor checklist and check if Travis or Codacy found any issues with your PR. Also make sure your commits are signed, and that you applied Bisq's code style and formatting.
A maintainer will add an is:priority label to your PR if it is up for compensation. Please see our Bisq Q1 2020 Update post for more details.
![boring-cyborg[bot] avatar](https://avatars.githubusercontent.com/in/50386?v=4 "Published by a pub.dev verified publisher"){kind=small}
@Android-X13 looks great. May I request an additional thing? Could you fix the clickable area of toggle buttons in DAO -> Facts & Figures -> Bsq Supply screen? There its possible to click on a toggle button and it toggles the one below.
Hi @jmacxx, The author of the relevant code resorted to a hack in order to decrease the height of the switches and the vertical gap between them:
The switches work best in their default height although the gaps increase quite enough which isn't what was wanted. Unless there's a better way to shrink the toggle's height symmetrically instead of doing hacks, my only solution to this would be to decrease the overlapping between them. But this would mean that their vertical gaps would increase a bit. And the clickable area still won't be ideal (but it will be better than now). If you still want this, should I push it in this branch?
the clickable area still won't be ideal (but it will be better than now).
Yes, I think an improvement would be worth it. To my mind it is similar enough to include in this branch. Thanks.
Before:
After:
The clickabe area is better now and the vertical distance between the switches isn't increased (too) much. It could be better but the gaps would also grow more.. I think the compromise between height and clickable areas is acceptable now
Kindly disregard my ramblings in the last comment above. The vertical gaps between toggles in BSQ SUPPLY do increase like shown, but their clickable area is ideal now.
Also, somehow I managed to screw up this PR. Really sorry about that. I'm new to git...