bisq icon indicating copy to clipboard operation
bisq copied to clipboard
verified publisher icon bisq-network

"Deactivating open offer due to mempool validation" does not produce any GUI explanation

Open JeremyRand opened this issue 3 years ago • 3 comments

Description

The "Deactivating open offer due to mempool validation" error (introduced by https://github.com/bisq-network/bisq/pull/5160 ) does not result in any GUI prompt telling the user what's wrong. The user must check the log file to gain any understanding of why their offer spontaneously disabled itself (and the GUI does not instruct the user to check the log). This is a UX issue.

Version

v1.8.4.

Steps to reproduce

  1. Have an open offer that fails mempool validation.
  2. Enable it by clicking the Status toggle.
  3. Wait a few minutes.

Expected behaviour

When the offer disables itself, the GUI should display a message somewhere (perhaps as an icon with popup next to the offer) that explains why the offer was disabled, and preferably give some suggestions on how to fix it.

Actual behaviour

No indication in the GUI is given as to what's wrong. The offer just disables itself without explanation. User has to think of checking the logs to figure out what happened.

Screenshots

N/A (issue is lack of GUI, not a bug in GUI that exists).

Device or machine

Haswell i7, Whonix 16 inside Qubes 4.1.

Additional info

N/A.

JeremyRand avatar Apr 02 '22 00:04 JeremyRand

Thanks for the writeup. I agree, whenever user's offers are auto-disabled it does cause support issues. The most common cause is an offer that has a maker Txid which cannot be found. Perhaps the best way to handle that would be an informational popup advising the user to delete the offer(s) and do an SPV resync.

jmacxx avatar Apr 03 '22 04:04 jmacxx

info

Probably it could be similar popup like we have when bsq swap offer has missing funds :point_up: Let me know if you agree, I could implement it then.

ghost avatar Apr 05 '22 10:04 ghost

@xyzmaker123 No objection here.

JeremyRand avatar Apr 08 '22 02:04 JeremyRand

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

github-actions[bot] avatar Sep 07 '23 00:09 github-actions[bot]

Are there any plans to get this done? Currently I get many offers deactivated due to mempool validation. Not only that there is no indication for the reason of deactivation, but no notification at all that offers were automatically deactivated.

At lease a notification telling the user that offers are deactivated should be given and preferably a reason.

worminder avatar Sep 07 '23 08:09 worminder

I am currently seeing this issue - what exactly does it mean to "fail mempool validation?" How would one go about fixing that?

snex avatar Nov 06 '23 18:11 snex