bisq icon indicating copy to clipboard operation
bisq copied to clipboard

Edit BSQ swap offer

Open xyzmaker123 opened this issue 2 years ago • 5 comments

Fixes #6075 Made it possible to edit price.

Screenshots:

bsq-swap-edit-offer


bsq-swap-edit-offer-2

xyzmaker123 avatar Mar 22 '22 15:03 xyzmaker123

@xyzmaker123 As no fees are being paid for BSQ offers I think to edit a BSQ offer it causes less code changes if you just remove the old one and open a new create offer view with pre-populated fields similar as it is done when cloning an BSQ offer. But please wait with this until #6135 is merged as lot of code that you would touch is going to be changed.

ripcurlx avatar Apr 21 '22 08:04 ripcurlx

@ripcurlx I rebased into master and resolved conflicts

just remove the old one and open a new create offer

I think it's not good approach:

  • it would be not possible to cancel edit offer
  • not consistent UI behavior in comparison with other offers edition

ghost avatar Apr 23 '22 16:04 ghost

As I don't remember anymore if there was a reason (besides that there are no fees paid, so no loss when deleting an offer) I'd like to have @chimp1984 opinion on this as well.

ripcurlx avatar May 05 '22 07:05 ripcurlx

I do not remember any reason preventing that, but as you said as canceling an offer is without costs it was easier to cancel and re-create. I don't have time atm to review the changes. Its non trivial changes so should be reviewed with care.

chimp1984 avatar May 05 '22 07:05 chimp1984

I do recall @sqrrm saying he never intended to make swap offers editable because cancelling them is free.

If they become editable in UI, I will eventually need to make them editable in the API -- that is also a non-trivial change on both the CLI and server (daemon) side.

ghubstan avatar May 05 '22 12:05 ghubstan