bisq icon indicating copy to clipboard operation
bisq copied to clipboard

Published 20 hours ago • verified publisher icon bisq-network

[1.8.3] Edit BSQ swap offer in offer book goes to nowhere

Open ripcurlx opened this issue 2 years ago • 5 comments

As it is not possible to edit a BSQ swap offer clicking on edit offer on a BSQ swap offer will take the user to my open offers and not as expected to an edit offer screen.

Version

1.8.2+

Steps to reproduce

  • Create BSQ swap offer
  • Click on edit offer in offer book

Expected behaviour

There shouldn't be an edit button for BSQ swap offers

Actual behaviour

Edit offer button takes users to my open offers

Screenshots

Bildschirmfoto 2022-02-24 um 10 43 56 Bildschirmfoto 2022-02-24 um 10 45 07

ripcurlx avatar Feb 24 '22 09:02 ripcurlx

@xyzmaker123 Could you please fix this wrong behavior? Thanks!

ripcurlx avatar Feb 24 '22 09:02 ripcurlx

Would it be possible for edit offer to be used to create a new offer whilst simultaneously deleting the existing offer?

pazza83 avatar Feb 24 '22 22:02 pazza83

Would it be possible for edit offer to be used to create a new offer whilst simultaneously deleting the existing offer?

Yes, that would be possible instead as well.

ripcurlx avatar Feb 25 '22 14:02 ripcurlx

Yes, that would be possible instead as well.

Great, I think that would be the best way to implement an edit of a BSQ swap as it keeps user experience consistent.

pazza83 avatar Mar 01 '22 02:03 pazza83

Would it be possible for edit offer to be used to create a new offer whilst simultaneously deleting the existing offer?

OK - I'll implement it that way

ghost avatar Mar 01 '22 10:03 ghost