bisq icon indicating copy to clipboard operation
bisq copied to clipboard

[v1.6.5] Handle send amounts below dust more gracefully

Open ripcurlx opened this issue 3 years ago • 1 comments

Description

We shouldn't get to the point showing a IllegalArgumentException when an amount below the dust limit is entered.

Version

v1.6.5

Steps to reproduce

Send funds from wallet and try to send an amount below dust limit

Expected behaviour

An validation error is displayed and Withdraw selected can't be pressed.

Actual behaviour

Withraw selected can be triggered and an java.lang.IllegalArgumentException: The amount is too low (dust limit). is surfaced.

Screenshots

Bildschirmfoto 2021-05-26 um 11 01 20

ripcurlx avatar May 26 '21 09:05 ripcurlx

It's quite complex task - on withdrawal screen every validation error is displayed in warning popup:

not-funds validation

I think we should either rebuild validation system on this screen to always show message under appropriate field and block action button, or (the minimum solution) just remove java.lang.IllegalArgumentException prefix from current popup. WDYT?

ghost avatar Aug 09 '22 11:08 ghost