bisq icon indicating copy to clipboard operation
bisq copied to clipboard

DAO and Fund section in Bisq seems to be missing ability to copy links

Open pazza83 opened this issue 3 years ago • 11 comments

Description

A minor annoyance of mine but the whole DAO and Fund section in Bisq seems to be missing ability to copy links.

Links all have a little link icon. They all seem to be missing the little copy icon.

This is most annoying when doing a transaction and then providing the Tx ID. Currently I users have to visit the website and then copy the Tx ID from the URL or the webpage. It would be much easier if users could just press the little 'copy icon'. It would also reduce the risk of user less error,

Version

v1.5.9

Steps to reproduce

Go to the DAO section is Bisq (No option to copy links in multiple sections) Go to the Funds section is Bisq (No option to copy links in multiple sections)

You can copy from places such as Trade ID details screen

Expected behaviour

Go to the DAO section is Bisq (option to copy links in multiple sections) Go to the Funds section is Bisq (option to copy links in multiple sections)

Use the same icon as in the Trade ID details screen

Screenshots

funds - Copy No option to copy Tx ID

bonds - Copy No option to copy Tx Id or GitHub issue

pazza83 avatar Mar 06 '21 01:03 pazza83

I can take care of this.

BtcContributor avatar Mar 06 '21 09:03 BtcContributor

Update: I had several testing to do for Bisq and other fixes but I already started with this. It will be released ASAP.

BtcContributor avatar Mar 27 '21 20:03 BtcContributor

Hi @BtcContributor how are you progressing with this issue?

pazza83 avatar May 16 '21 23:05 pazza83

Hi @pazza83, unfortunately this is stuck at this moment as I had other tasks to do.

Btw, I am honestly having some issues implementing the fix, so if this is high priority please assign it to someone else.

BtcContributor avatar May 17 '21 07:05 BtcContributor

Hi @BtcContributor thanks for letting me know.

@xyzmaker123 let me know if you would like to work on this issue.

pazza83 avatar Sep 23 '21 07:09 pazza83

@pazza83 There is no "copy" button there, but links are clickable (after click browser with btc/bsq explorer is opened). Isn't it enough?

ghost avatar Sep 28 '21 10:09 ghost

Hi @xyzmaker123 the copy button is more secure, private and user friendly.

When trying to get transaction IDs you are forced to open a new window with a blockchain explorer and then copy the transaction ID from that site. This has some privacy concerns and creates a second point of error that you are copying the transaction id from a 3rd party website not from within your Bisq app.

pazza83 avatar Sep 28 '21 13:09 pazza83

Hi @xyzmaker123 the copy button is more secure, private and user friendly.

When trying to get transaction IDs you are forced to open a new window with a blockchain explorer and then copy the transaction ID from that site. This has some privacy concerns and creates a second point of error that you are copying the transaction id from a 3rd party website not from within your Bisq app.

But you are asked the first time you click on such link if you just want to copy them or open them within a browser.

ripcurlx avatar Sep 30 '21 08:09 ripcurlx

@ripcurlx Got it - just wanted to be sure everybody agree we want this feature.

ghost avatar Sep 30 '21 08:09 ghost

The problem I see with this feature request is the concrete implementation part. ATM there is the icon for the link, which is used everywhere in the client. When we want to introduce the copy icon, where should it be? Next to the link icon would be confusing IMO.

ripcurlx avatar Oct 04 '21 08:10 ripcurlx

Hi @ripcurlx

Maybe having the transaction IDs selectable / copy-able as per @jmacxx's solution here https://github.com/bisq-network/bisq/pull/5747 would work.

Main issue is trying to navigate the DAO > Wallet > Transaction information none of the text is able to be selected.

pazza83 avatar Oct 17 '21 01:10 pazza83