biscuit-rust icon indicating copy to clipboard operation
biscuit-rust copied to clipboard

Don’t merge: candidate branch with outstanding v5 features

Open divarvel opened this issue 1 year ago • 1 comments

divarvel avatar Oct 23 '24 12:10 divarvel

CodSpeed Performance Report

Merging #235 will not alter performance

Comparing kitchensink (17c7784) with v5 (e59f41d)

Summary

✅ 12 untouched benchmarks

codspeed-hq[bot] avatar Oct 23 '24 12:10 codspeed-hq[bot]

Codecov Report

Attention: Patch coverage is 54.39560% with 83 lines in your changes missing coverage. Please review.

Project coverage is 68.30%. Comparing base (d90accd) to head (17c7784). Report is 4 commits behind head on v5.

Files with missing lines Patch % Lines
biscuit-auth/src/token/builder.rs 16.07% 47 Missing :warning:
biscuit-auth/src/format/convert.rs 63.79% 21 Missing :warning:
biscuit-auth/src/token/authorizer.rs 50.00% 8 Missing :warning:
biscuit-auth/src/datalog/expression.rs 88.23% 4 Missing :warning:
biscuit-parser/src/builder.rs 0.00% 2 Missing :warning:
biscuit-auth/src/token/authorizer/snapshot.rs 0.00% 1 Missing :warning:
Additional details and impacted files
@@            Coverage Diff             @@
##               v5     #235      +/-   ##
==========================================
- Coverage   68.96%   68.30%   -0.66%     
==========================================
  Files          25       25              
  Lines        5922     6039     +117     
==========================================
+ Hits         4084     4125      +41     
- Misses       1838     1914      +76     

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

codecov[bot] avatar Nov 05 '24 13:11 codecov[bot]

everything has been merged except the FFI branch so no need for this branch anymore

divarvel avatar Nov 18 '24 08:11 divarvel