biscuit-java icon indicating copy to clipboard operation
biscuit-java copied to clipboard

samples verify block by block

Open KannarFr opened this issue 1 year ago • 1 comments

This is DRAFT.

KannarFr avatar Apr 08 '24 15:04 KannarFr

BTW is there a good way in maven to capture stdout in tests, so that we only display it for tests that failed?

Geal avatar Apr 14 '24 15:04 Geal

https://github.com/biscuit-auth/biscuit-java/pull/94 merges the parts of this PR that were already usable, leaving the samples block checks and the Parser.datalog method.

Right now I am not too convinced about the implementation of that method that does manual string manipulations. An implementation that follows the rest of the parser, using parser combinators, would fit better here and prevent errors. The Rust reference implementation can be used as inspiration here https://github.com/biscuit-auth/biscuit-rust/blob/main/biscuit-parser/src/parser.rs#L895-L970

Geal avatar May 01 '24 12:05 Geal

closing this since it has been merged as part of https://github.com/biscuit-auth/biscuit-java/pull/102

Geal avatar Jun 15 '24 15:06 Geal