obsidian-adwaita-theme icon indicating copy to clipboard operation
obsidian-adwaita-theme copied to clipboard

Swap Colors for official GNOME names and move to seperate file

Open Haaruun-I opened this issue 2 years ago • 5 comments

exactly what the title says, light mode is slightly off but the gradiance integration should fix it

Haaruun-I avatar Jan 07 '23 13:01 Haaruun-I

Thank you for your work. Looks good but it think it requires some refinement.

  • Dark and Light theme should work even without the Gradience integration
  • to avoid variable naming conflicts we should add some prefix e.g. adw-
  • i think the tilebar-background should be the headerbar-backdrop-color
  • i am not sure why you removed the .is-focused rules

birneee avatar Jan 08 '23 13:01 birneee

Hi, sorry for the late reply, i was a bit busy this week About those isues,

  • The only issue with light theme the highlight color matching the background on the file picker sidebar, which means it only gets bolded and not a background change image
  • Good idea, ill do that now
  • same ^
  • I didnt see the focused colors used anywhere and they were the same colors as the non-focused most of the times anyways

Haaruun-I avatar Jan 15 '23 06:01 Haaruun-I

@Haaruun-I The focused colors are used, when the window is in focus.

birneee avatar Jan 22 '23 15:01 birneee

@Haaruun-I for me the light theme looks quite unusable. Does it look different for you?

When window in focus: Screenshot from 2023-01-22 15-59-08

When window not in focus: Screenshot from 2023-01-22 15-59-27

birneee avatar Jan 22 '23 15:01 birneee

https://github.com/birneee/obsidian-adwaita-theme/commit/d6ceb701123b3627c6183a5f66eb8f246a2805fb

birneee avatar Jul 30 '23 21:07 birneee