Georg Brandl

Results 129 comments of Georg Brandl

I agree that the syntax needs to be more explicit and consistent. Option 2, although attractive for DRY, is a non-starter IMO since tools other than rustc just that ignore...

Yes please! I was already wondering why the repo is so big. Alternately, the `gh-pages` can be put into a separate repo.

> Oops, `keep_files` does not work with `force_orphan`. The `redirect` step might not need `force_orphan` though?

Last time I checked, nextest did not support and run doctests. So you'd have to add "cargo test --doc" as a separate step?

Small correction, needs to be `|val| &val.inner|`.

You can't take ownership of `self` since it's wrapped by a Python object, and that Python object can be referenced anywhere. But the error could be better, so let's keep...

Also, the guide only says "`&self` and `&mut self` can be used" about instance methods. This should be expanded to cover the other possible receivers, and the caveats with `&mut...

Yes, or something like `enum Socket { Tcp(TcpStream), Udp(UdpSocket) [, None] }`

I would be wary of that. I've fought quite a few "underlying C++ object has been deleted" problems in PyQt which is the equivalent.

This is definitely interesting, but: * I'd let Python's `match` conventions shake out themselves for at least a release * better support for enums should be not only 3.10+