bioperl-live icon indicating copy to clipboard operation
bioperl-live copied to clipboard

Published 20 hours ago • verified publisher icon bioperl

Simplealign

Open yinjun111 opened this issue 11 years ago • 10 comments

Hi, Chris,

This is my implementation of Bio::SimpleAlign. I have a detailed report describing the improvement to the code, and explaining the failed tests using t/Align/SimpleAlign.t. If you need any help, please just let me know.

Cheers, Jun

yinjun111 avatar Oct 03 '12 14:10 yinjun111

Oops - comments from me not a student in my class...

So this currently fails in the travis build -- can someone comment about what it will take to fix it. Where is the detailed report on what was added Jun - is it in the code or in a mail to the mailing list?

hyphaltip avatar Oct 09 '12 16:10 hyphaltip

I have send the update log to Chris Fields, who was my mentor during my coding project in Google summer of code. I think I can put the update log in the BioPerl wiki, so everybody can see it. If you pull the new SimpleAlign code, you will expect some failed tests from t/Align/SimpleAlign.t, you will see the explanation in the report.

yinjun111 avatar Oct 09 '12 16:10 yinjun111

See the wiki page for details of the updates: http://www.bioperl.org/wiki/SimpleAlign_Updates#Abstract

yinjun111 avatar Oct 09 '12 17:10 yinjun111

Without objection I'll be reviewing and merging the 3 open github pull requests this week.

jhannah avatar Feb 05 '13 17:02 jhannah

Hi, Jay,

I notice that there is no revision on the SimpleAlign code for the last few months. So this implementation should work without problem using the SimpleAlign2.t provided. Let me know if you need any clarification.

Cheers, Jun

yinjun111 avatar Feb 05 '13 18:02 yinjun111

We have failing Travis-CI at the moment, so hold off on a merge. We're planning on a new point release of BioPerl 1.6.x in about 1 month, we might want to wait before merging this one in.

cjfields avatar Feb 09 '13 05:02 cjfields

Jun, after a long long wait I'm finally getting around to reviewing these. I've pulled them into a separate branch from master and will merge back in after checking tests.

cjfields avatar Aug 09 '13 17:08 cjfields

Hi, Chris,

You will have some errors from the old t/Align/SimpleAlign.t. You can try t/Align/SimpleAlign2.t, which is edited to test the new Bio::SimpleAlign

yinjun111 avatar Aug 10 '13 20:08 yinjun111

I saw the errors. Do you recall whether these are failing b/c the implementation details changed, or where the tests erroneous to begin with?

cjfields avatar Aug 10 '13 21:08 cjfields

These are mainly caused by different implementation of several methods. The changes are listed in the BioPerl wiki. http://www.bioperl.org/wiki/SimpleAlign_Updates#Abstract

yinjun111 avatar Aug 12 '13 00:08 yinjun111