bioperl-live icon indicating copy to clipboard operation
bioperl-live copied to clipboard

fix for writing large_fasta sequences

Open epaule opened this issue 2 years ago • 2 comments

  • the window count was off for cases where the sequence length aligned with the window size
  • i also bumped up the max buffer size

epaule avatar Apr 27 '22 12:04 epaule

I haven't tested this yet myself but this seems like an appropriate update - is there a performance improvement or a particular bug this fixes?

hyphaltip avatar Apr 27 '22 20:04 hyphaltip

it fixes a bug: namely that it tried to write past the end of the sequence in cases where the number of base pairs of the last window aligned with the window. It then tried to write bp end+1 to end.

epaule avatar Apr 29 '22 09:04 epaule

Awesome, thanks for the addition @epaule !

cjfields avatar Sep 12 '22 21:09 cjfields