bioperl-live icon indicating copy to clipboard operation
bioperl-live copied to clipboard

Minus and Plus HSP misattributed

Open FredericBGA opened this issue 5 years ago • 1 comments

It should be $qpmax; and $qpmin; right ? https://github.com/bioperl/bioperl-live/blob/7cc47700c5ee5aed5e6a32966b86628c28b6b127/lib/Bio/SearchIO/Writer/GbrowseGFF.pm#L267 https://github.com/bioperl/bioperl-live/blob/7cc47700c5ee5aed5e6a32966b86628c28b6b127/lib/Bio/SearchIO/Writer/GbrowseGFF.pm#L268

It should be $qmmax; and $qmmin; right ? https://github.com/bioperl/bioperl-live/blob/7cc47700c5ee5aed5e6a32966b86628c28b6b127/lib/Bio/SearchIO/Writer/GbrowseGFF.pm#L296 https://github.com/bioperl/bioperl-live/blob/7cc47700c5ee5aed5e6a32966b86628c28b6b127/lib/Bio/SearchIO/Writer/GbrowseGFF.pm#L297

FredericBGA avatar Feb 19 '19 08:02 FredericBGA

Possibly, the issue is we don't have tests in place to know.

We would preferably have some basic minimal test for evaluating correctness within the test suite, except this module doesn't have great tests to check for correctness with the output; note that this only checks to makes sure a file is generated:

https://github.com/bioperl/bioperl-live/blob/master/t/SearchIO/Writer/GbrowseGFF.t

We gladly take pull requests for this, though, and if you have even some basic tests we will gladly accept them and add you to the contributors.

cjfields avatar Mar 09 '19 16:03 cjfields