bioperl-live icon indicating copy to clipboard operation
bioperl-live copied to clipboard

Published 20 hours ago • verified publisher icon bioperl

multiple modules assign to $VERSION

Open carandraug opened this issue 5 years ago • 4 comments

We have $Bio::Root::Version::VERSION but that seems to not be good enough to some modules that have their own indepdendent VERSION. These are:

  • Bio/Root/Root.pm
  • Bio/Root/Build.pm
  • BioPerl.pm

which just set it to the same as $Bio::Root::Version::VERSION

But there is also DB/SeqFeature/Store/LoadHelper.pm which has its own $VERSION still set to 1.12.

carandraug avatar Sep 17 '18 13:09 carandraug

I have removed all of this stuff, and the VERSIONs get added to all modules automatically during authoring of the distribution.

This is done automatically to all modules, so there's no more need for a system to keep the version number synchronized. So should the whole Bio::Root::Version be deprecated?

carandraug avatar Sep 30 '18 22:09 carandraug

@carandraug re: Bio::Root::Version being deprecated: yes it should be. It's past it's useful life.

cjfields avatar Oct 07 '18 02:10 cjfields

Maybe let's make a release where the only change is splitting of bioperl, and then mark it as deprecated?

carandraug avatar Oct 07 '18 22:10 carandraug

@carandraug Works for me.

Side note: It may be worth opening a ticket regarding packaging at some point. I pointed out to Torsten Seemann (Prokka) that this is going on. Seemed the consensus may be to target Bundle-BioPerl for some tools that aren't on CPAN and may not have their dependencies explicitly worked out yet.

cjfields avatar Oct 08 '18 03:10 cjfields