bionitio icon indicating copy to clipboard operation
bionitio copied to clipboard

Missing expected file still passes

Open trickytank opened this issue 5 years ago • 0 comments

Using the Python mode, I found that if the expected file was missing that the test still passes.

The line starting with "diff" indicates a file is missing, but the test still parsed and successfully passed Travis CI.

(biodemo_dev) ubuntu@None:~/code/biodemo/functional_tests$ ./biodemo-test.sh -p biodemo -d test_data -v
biodemo-test.sh Testing stdout and exit status: biodemo one_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --minlen 200 two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --minlen 200 < two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo empty_file
biodemo-test.sh Testing stdout and exit status: biodemo --minlen 1000 two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --maxlen 170 two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --maxlen 170 < two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --maxlen 10 two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --minlen 10 --maxlen 1000 two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --minlen 200 --maxlen 10 two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --minlen 200 --maxlen 1000 two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --minlen 10 --maxlen 170 two_sequence.fasta
biodemo-test.sh Testing stdout and exit status: biodemo --minlen 50 --maxlen 340 < two_sequence.fasta
diff: two_sequence.fasta.stdin.expected: No such file or directory
biodemo-test.sh Testing exit status: biodemo --this_is_not_a_valid_argument > /dev/null 2>&1
biodemo-test.sh Testing exit status: biodemo this_file_does_not_exist.fasta > /dev/null 2>&1
biodemo passed all 16 successfully

A (semi) reproducible example is at: https://github.com/trickytank/biodemo/commit/d6d3f4aba7a2d934f98609771a76a7f57620a9e6

Travis CI: https://travis-ci.org/trickytank/biodemo/builds/461596203

trickytank avatar Nov 30 '18 03:11 trickytank