biomejs
💅 `useExhaustiveDependencies` does not recognize variables declared later as dependencies
Environment information
CLI:
Version: 1.8.2
Color support: true
Platform:
CPU Architecture: x86_64
OS: linux
Environment:
BIOME_LOG_DIR: unset
NO_COLOR: unset
TERM: "xterm-256color"
JS_RUNTIME_VERSION: "v18.18.0"
JS_RUNTIME_NAME: "node"
NODE_PACKAGE_MANAGER: "pnpm/8.7.6"
Biome Configuration:
Status: Loaded successfully
Formatter disabled: false
Linter disabled: false
Organize imports disabled: false
VCS disabled: true
Linter:
JavaScript enabled: true
JSON enabled: true
CSS enabled: false
Recommended: true
All: false
Enabled rules:
performance/noDelete
suspicious/noCatchAssign
suspicious/noUnsafeNegation
complexity/useLiteralKeys
style/useImportType
complexity/noMultipleSpacesInRegularExpressionLiterals
a11y/useValidLang
complexity/noUselessEmptyExport
suspicious/useNamespaceKeyword
suspicious/useValidTypeof
a11y/useValidAriaRole
correctness/noConstantCondition
a11y/useAriaActivedescendantWithTabindex
suspicious/noAssignInExpressions
style/useDefaultParameterLast
complexity/noEmptyTypeParameters
correctness/noConstructorReturn
style/useSelfClosingElements
suspicious/noDuplicateParameters
style/useTemplate
correctness/noUnusedLabels
complexity/noUselessTernary
correctness/noUnreachableSuper
suspicious/noCompareNegZero
suspicious/noExplicitAny
correctness/noSwitchDeclarations
a11y/noAutofocus
correctness/noUnsafeOptionalChaining
correctness/noConstAssign
suspicious/noControlCharactersInRegex
complexity/noUselessTypeConstraint
style/noVar
suspicious/noDoubleEquals
suspicious/noRedundantUseStrict
style/useLiteralEnumMembers
suspicious/noGlobalIsNan
suspicious/noEmptyInterface
suspicious/noConstEnum
suspicious/noMisleadingCharacterClass
correctness/noPrecisionLoss
suspicious/noRedeclare
correctness/noStringCaseMismatch
correctness/noSetterReturn
correctness/noInvalidConstructorSuper
suspicious/noImplicitAnyLet
suspicious/noFallthroughSwitchClause
suspicious/noUnsafeDeclarationMerging
correctness/noUnreachable
a11y/useKeyWithClickEvents
suspicious/noDuplicateObjectKeys
complexity/noUselessThisAlias
complexity/noThisInStatic
complexity/useOptionalChain
correctness/noInnerDeclarations
style/noParameterAssign
suspicious/noDuplicateCase
a11y/useValidAnchor
complexity/useRegexLiterals
correctness/noSelfAssign
style/noUselessElse
style/useShorthandFunctionType
suspicious/noShadowRestrictedNames
a11y/useMediaCaption
complexity/noUselessLabel
complexity/noUselessCatch
correctness/noUnsafeFinally
a11y/useAriaPropsForRole
correctness/noNonoctalDecimalEscape
style/useEnumInitializers
a11y/useHtmlLang
suspicious/noDuplicateTestHooks
complexity/noStaticOnlyClass
style/useWhile
complexity/useArrowFunction
style/noInferrableTypes
a11y/noNoninteractiveTabindex
complexity/useSimpleNumberKeys
correctness/useYield
a11y/noInteractiveElementToNoninteractiveRole
style/useNumericLiterals
correctness/noUnnecessaryContinue
suspicious/noApproximativeNumericConstant
suspicious/noImportAssign
suspicious/noLabelVar
correctness/noGlobalObjectCalls
suspicious/useDefaultSwitchClauseLast
a11y/useAltText
correctness/noEmptyCharacterClassInRegex
suspicious/noSuspiciousSemicolonInJsx
suspicious/noSparseArray
a11y/useIframeTitle
complexity/noBannedTypes
a11y/noSvgWithoutTitle
correctness/noVoidElementsWithChildren
style/useAsConstAssertion
correctness/useJsxKeyInIterable
style/useExportType
complexity/noUselessLoneBlockStatements
suspicious/noPrototypeBuiltins
suspicious/noMisleadingInstantiator
suspicious/noDebugger
style/noArguments
a11y/useValidAriaValues
suspicious/noCommentText
suspicious/noThenProperty
suspicious/noDuplicateJsxProps
suspicious/noGlobalAssign
a11y/noPositiveTabindex
correctness/noEmptyPattern
complexity/noExcessiveNestedTestSuites
security/noDangerouslySetInnerHtmlWithChildren
a11y/useKeyWithMouseEvents
suspicious/noExtraNonNullAssertion
suspicious/useGetterReturn
correctness/noRenderReturnValue
correctness/useExhaustiveDependencies
security/noGlobalEval
style/noNonNullAssertion
a11y/noRedundantRoles
complexity/useFlatMap
correctness/useIsNan
style/useConst
suspicious/noGlobalIsFinite
suspicious/noSelfCompare
suspicious/noAsyncPromiseExecutor
security/noDangerouslySetInnerHtml
style/useNodejsImportProtocol
a11y/noDistractingElements
suspicious/noArrayIndexKey
complexity/noWith
suspicious/noDuplicateClassMembers
complexity/noExtraBooleanCast
performance/noAccumulatingSpread
a11y/useValidAriaProps
a11y/noRedundantAlt
correctness/noChildrenProp
suspicious/noConfusingLabels
suspicious/noConfusingVoidType
suspicious/noFocusedTests
a11y/useButtonType
a11y/noAriaUnsupportedElements
correctness/noFlatMapIdentity
a11y/noBlankTarget
a11y/useHeadingContent
correctness/useValidForDirection
correctness/noVoidTypeReturn
correctness/noInvalidUseBeforeDeclaration
a11y/noAriaHiddenOnFocusable
a11y/useAnchorContent
complexity/noUselessRename
correctness/noInvalidNewBuiltin
style/useNumberNamespace
complexity/noUselessConstructor
a11y/noAccessKey
style/useExponentiationOperator
style/noUnusedTemplateLiteral
complexity/noUselessSwitchCase
style/useSingleVarDeclarator
suspicious/noExportsInTest
a11y/noNoninteractiveElementToInteractiveRole
style/noCommaOperator
suspicious/useIsArray
a11y/noHeaderScope
complexity/noUselessFragments
suspicious/noMisrefactoredShorthandAssign
complexity/noForEach
suspicious/noClassAssign
suspicious/noFunctionAssign
Workspace:
Open Documents: 0
Rule name
useExhaustiveDependencies
Playground link
https://biomejs.dev/playground/?code=aQBtAHAAbwByAHQAIAB7ACAAdQBzAGUAUwB0AGEAdABlACwAIAB1AHMAZQBFAGYAZgBlAGMAdAAgAH0AIABmAHIAbwBtACAAJwByAGUAYQBjAHQAJwAKAAoAZgB1AG4AYwB0AGkAbwBuACAARgBvAG8AQwBvAG0AcABvAG4AZQBuAHQAKAApACAAewAKACAAIABjAG8AbgBzAHQAIABbAHMAdABhAHQAZQAsACAAcwBlAHQAUwB0AGEAdABlAF0AIAA9ACAAdQBzAGUAUwB0AGEAdABlACgAJwBmAG8AbwAnACkACgAgACAAdQBzAGUARQBmAGYAZQBjAHQAKAAoACkAIAA9AD4AIAB7AAoAIAAgACAAIABjAG8AbgBzAG8AbABlAC4AbABvAGcAKABzAHQAYQB0AGUAKQAKACAAIAB9ACwAIABbAF0AKQAKAAoAIAAgAHIAZQB0AHUAcgBuACAAbgB1AGwAbAAKAH0ACgAKAGYAdQBuAGMAdABpAG8AbgAgAEIAYQByAEMAbwBtAHAAbwBuAGUAbgB0ACgAKQAgAHsACgAgACAAdQBzAGUARQBmAGYAZQBjAHQAKAAoACkAIAA9AD4AIAB7AAoAIAAgACAAIABjAG8AbgBzAG8AbABlAC4AbABvAGcAKABzAHQAYQB0AGUAKQAKACAAIAB9ACwAIABbAF0AKQAKACAAIABjAG8AbgBzAHQAIABbAHMAdABhAHQAZQAsACAAcwBlAHQAUwB0AGEAdABlAF0AIAA9ACAAdQBzAGUAUwB0AGEAdABlACgAJwBiAGEAcgAnACkACgAKACAAIAByAGUAdAB1AHIAbgAgAG4AdQBsAGwACgB9AA%3D%3D
Expected result
Both should result in an error. (Both resulted in an error with the ESLint plugin.)
Code of Conduct
- [X] I agree to follow Biome's Code of Conduct
There seems something off with our js scope analysis. We have this test case in the file
https://github.com/biomejs/biome/blob/b3d8bfdf1ddedeccc60028a6c05f7fbb0d0079e9/crates/biome_js_semantic/src/semantic_model/closure.rs#L438-L440
But if I change it to this it will fail:
let two_captures = "function f(c) {console.log(a, b, c)} let a, b;"; // move function definition to the front
assert_closure(two_captures, "f", &["a", "b"]);
assert_eq!(get_closure_children(two_captures, "f").len(), 0);
This still seems to be an issue in both v1.9.x and v2.0.x-beta. Is there any hope this would get resolved by 2.0.0? The question came up that you would be careful to suggest adding later-defined variables to the deps array but I think for a linter that's fine to do. They aren't safe fixes anyway, and this is how react-hooks/exhaustive-deps already works. Given this, would it be okay to ensure all deps are adding, even if they are defined after the useEffect/useCallback?
Simple example
export function Main() {
const foo = Date.now();
useEffect(() => {
alert(`foo: ${foo}`);
alert(`bar: ${bar}`);
}, []); // alerts about 'foo' but misses 'bar'. Should alert both.
const bar = Date.now();
}
