biome icon indicating copy to clipboard operation
biome copied to clipboard

🐛 overrides overrides extends overrides 😂

Open unional opened this issue 2 months ago • 0 comments

Environment information

CLI:
  Version:                      1.7.2
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v20.10.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         "pnpm/9.0.6"

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    true
  VCS disabled:                 true

Workspace:
  Open Documents:               0

What happened?

// biome.json
{
  "extends": ["./some-config.json"],
  "overrides": [{...}]
}

/// some-config.json
{
  "overrides": [{...}, { "include": ["package.json"], "formatter": { "lineWidth": 20 } }]
}

The overrides in biome.json overrides overrides in some-config.json

specifically, I observe the package.json override does not work until I do:

// biome.json
{
  "extends": ["./some-config.json"],
  "overrides": [{...}, { "include": ["package.json"], "formatter": { "lineWidth": 20 } }]
}

Expected result

The overrides in biome.json concatenates overrides in some-config.json

Code of Conduct

  • [X] I agree to follow Biome's Code of Conduct

unional avatar May 04 '24 22:05 unional