biome icon indicating copy to clipboard operation
biome copied to clipboard

💅 useExhaustiveDependencies nested access check relies on the source format

Open XiNiHa opened this issue 2 years ago • 1 comments

Environment information

CLI:
  Version:                      1.4.1
  Color support:                true

Platform:
  CPU Architecture:             x86_64
  OS:                           linux

Environment:
  BIOME_LOG_DIR:                unset
  NO_COLOR:                     unset
  TERM:                         "xterm-256color"
  JS_RUNTIME_VERSION:           "v18.14.0"
  JS_RUNTIME_NAME:              "node"
  NODE_PACKAGE_MANAGER:         unset

Biome Configuration:
  Status:                       Loaded successfully
  Formatter disabled:           false
  Linter disabled:              false
  Organize imports disabled:    false
  VCS disabled:                 false

Workspace:
  Open Documents:               0

What happened?

The correctness/useExhaustiveDependencies rule works in different ways when the formatting differs.

Playground Link

Expected result

The formatting shouldn't matter.

Code of Conduct

  • [X] I agree to follow Biome's Code of Conduct

XiNiHa avatar Dec 02 '23 06:12 XiNiHa

It's because of using raw source strings to determine the object access overlap: source I'd like to contribute on this one.

XiNiHa avatar Dec 02 '23 06:12 XiNiHa