ontobio icon indicating copy to clipboard operation
ontobio copied to clipboard

Go site 676 gorule 0000022 check for retracted publications

Open mugitty opened this issue 1 month ago • 4 comments

mugitty avatar May 09 '24 20:05 mugitty

@mugitty It looks like the test error:

==================================== ERRORS ====================================
_______________ ERROR collecting tests/test_validation_rules.py ________________
tests/test_validation_rules.py:1: in <module>
    from ontobio.validation import rules
ontobio/validation/rules.py:11: in <module>
    from ontobio.validation import metadata
ontobio/validation/metadata.py:188: in <module>
    def retracted_pub_set(metadata)->set[str]:
E   TypeError: 'type' object is not subscriptable
=============================== warnings summary ===============================

is related to the handling of go-site metadata as mentioned above.

kltm avatar May 09 '24 21:05 kltm

@kltm , I did not realized that we wanted a flag to determine if the test should be run. So, it would only be in ontobio-parse-assocs.py as a parameter?

For the error, is it expecting set[] instead of set[str] due to version of python?

mugitty avatar May 09 '24 21:05 mugitty

@mugitty For me, I just want to make sure that the file is optional, and ideally be able to specify it in different contexts. The exact mechanism isn't too too important.

kltm avatar May 09 '24 22:05 kltm

Linking to issue geneontology/go-site#676

dustine32 avatar May 09 '24 23:05 dustine32