orange3 icon indicating copy to clipboard operation
orange3 copied to clipboard

Datasets: Add domain field

Open janezd opened this issue 1 year ago • 4 comments

Issue

When reimplementing the repository of data sets, we added a field "Domain". Its current values are "core" and "sc", but the plan was to add (a very limited) number of others, such as "Education", and to allow the user to select a domain in the Data sets widget. Domains were not meant to be like tags but rather to allow the user select a single specific domain.

Description of changes

This PR adds a combo for selection of domains.

The "core" domain is shown as "(general)".

The PR also modifies the current behaviour: with the new repo, the Data sets widget also showed the single-cell datasets (sc). Now it only shows them if they're specifically chosen.

Comments?

Includes
  • [X] Code changes
  • [X] Tests
  • [ ] Documentation

janezd avatar Oct 18 '24 19:10 janezd

Codecov Report

Attention: Patch coverage is 87.65432% with 10 lines in your changes missing coverage. Please review.

Project coverage is 88.39%. Comparing base (52df166) to head (300a753). Report is 126 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6920      +/-   ##
==========================================
+ Coverage   88.37%   88.39%   +0.01%     
==========================================
  Files         329      329              
  Lines       72447    72544      +97     
==========================================
+ Hits        64028    64125      +97     
  Misses       8419     8419              

codecov[bot] avatar Oct 18 '24 20:10 codecov[bot]

Would it be possible to make it so that if there is a specific addon installed which has datasetes available on the servers then this domain is also added automatically? Basically the addon would register the domain in the datasets widget...?

borondics avatar Oct 18 '24 20:10 borondics

This is not "domain" in the sense of internet domain. It's more like a field, a category ... The genesis of "domains" is that we have too many data sets that we need for teaching, so we want to separate them from other data sets. We also have data sets for the single-cell add-on, which are probably not useful for the majority of users.

The widget still shows only data sets served from a single server. If you have some data sets to add - from a specific domain -, we can upload them.

But your question is probably rather about adding other servers? We could let the user (or an add-on) add servers, but servers need to provide a json file in a particular not-so-well-documented format. I doubt many would set it up; if only the "official" add-ons would do so, it's simpler to put their corresponding data on the existing server. I think.

janezd avatar Oct 18 '24 20:10 janezd

I think I understood "domain" the way you originally meant it for the this PR.

We have some orange-spectroscopy datasets on the biolab server and they might be excluded with this new PR so I was wondering if we could enable the orange-spectroscopy addon (or any other) to include those files ("domain") if it is installed.

However, adding new servers sounds interesting too...

borondics avatar Oct 18 '24 22:10 borondics

We are going to move datasets between domains. Thus, it is critical that, as we just discussed, output the saved selected data set even if it was moved. And yes, we are both aware that this is going to be cumbersome.

markotoplak avatar Oct 23 '24 10:10 markotoplak