orange3 icon indicating copy to clipboard operation
orange3 copied to clipboard

Gradient Boosting - Remove try/catch around imports

Open PrimozGodec opened this issue 2 years ago • 5 comments

Issue

After https://github.com/biolab/orange3/pull/6570, try/catch around xgboost/catboost methods is not required anymore since packages are always installed

Description of changes

Remove try/catch around imports, skips in tests, and simplify parts of the code.

This PR also fix translations since the check is currently failing on the master.

Includes
  • [X] Code changes
  • [X] Tests
  • [ ] Documentation

PrimozGodec avatar Sep 21 '23 13:09 PrimozGodec

Come on, let's wait a bit with this so that we see if the added requirements create problems for anyone. I am making this a draft.

markotoplak avatar Sep 21 '23 17:09 markotoplak

/rebase

PrimozGodec avatar Jan 11 '24 16:01 PrimozGodec

Codecov Report

Merging #6584 (637f695) into master (7233533) will decrease coverage by 0.02%. The diff coverage is 100.00%.

:exclamation: Current head 637f695 differs from pull request most recent head 360b7b3. Consider uploading reports for the commit 360b7b3 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6584      +/-   ##
==========================================
- Coverage   88.07%   88.05%   -0.02%     
==========================================
  Files         322      322              
  Lines       70254    70226      -28     
==========================================
- Hits        61874    61841      -33     
- Misses       8380     8385       +5     

codecov[bot] avatar Jan 11 '24 17:01 codecov[bot]

I think it can be reviewed and merged now.

PrimozGodec avatar Jan 12 '24 07:01 PrimozGodec

I'd wait with this a little bit now that newest xgboost version started not packing libomp again. Perhaps we should even think about dropping the requirement...

markotoplak avatar Jul 26 '24 13:07 markotoplak