orange3 icon indicating copy to clipboard operation
orange3 copied to clipboard

Scatterplot: Fix crash for a single time tick

Open janezd opened this issue 3 years ago • 3 comments

Issue

Fixes #6086.

If there is only a single tick or no ticks, min that computed the min difference crashed.

Description of changes

Provide default argument. It equals the difference between the min and the max value, so tickStrings knows how to formulate the label.

Includes
  • [X] Code changes
  • [X] Tests

janezd avatar Sep 20 '22 18:09 janezd

test_pandas fails. Not my fault, or is it?

janezd avatar Sep 20 '22 18:09 janezd

test_pandas fails. Not my fault, or is it?

It isn't your fault. It may be due to the latest pandas release.

PrimozGodec avatar Sep 21 '22 10:09 PrimozGodec

Here is the PR that solves the issue https://github.com/biolab/orange3/pull/6145

PrimozGodec avatar Sep 21 '22 11:09 PrimozGodec

Codecov Report

Merging #6144 (e0ce236) into master (1d10fb4) will increase coverage by 0.00%. The diff coverage is 100.00%.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6144   +/-   ##
=======================================
  Coverage   86.45%   86.46%           
=======================================
  Files         315      315           
  Lines       67645    67645           
=======================================
+ Hits        58485    58488    +3     
+ Misses       9160     9157    -3     

codecov[bot] avatar Sep 21 '22 19:09 codecov[bot]