orange3 icon indicating copy to clipboard operation
orange3 copied to clipboard

Remove deprecated colorbrewer and colorpalette

Open PrimozGodec opened this issue 3 years ago • 5 comments

Issue

I just randomly found the colorbrewer and saw it is deprecated for a very long time. I think it is time to remove it.

Description of changes

Since colorbrewer and colorpalette are deprecated for long enough I propose deleting them.

Includes
  • [X] Code changes
  • [X] Tests
  • [ ] Documentation

PrimozGodec avatar Sep 12 '22 09:09 PrimozGodec

Codecov Report

Merging #6135 (b21b5d5) into master (2f2ca12) will increase coverage by 0.52%. The diff coverage is n/a.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6135      +/-   ##
==========================================
+ Coverage   86.46%   86.98%   +0.52%     
==========================================
  Files         315      313       -2     
  Lines       67607    66971     -636     
==========================================
- Hits        58456    58255     -201     
+ Misses       9151     8716     -435     

codecov[bot] avatar Sep 12 '22 09:09 codecov[bot]

I welcome removal of colorpalette because I always have to check whether to use colorpalette or colorpalettes.

I hope, though, that no-addons use it. Have you checked? (I don't have single cell and a few others.)

janezd avatar Sep 12 '22 12:09 janezd

I have believed it is already removed from add-ons since colorpalettes has been deprecated for two years, but that is not the case. It is still used in geo (tests only), bioinformatics, and image analytics. So this PR will need to sit here for a while before it can be merged.

I am working on replacing it with colorpalettes.

PrimozGodec avatar Sep 12 '22 14:09 PrimozGodec

I have believed it is already removed from add-ons since colorpalettes has been deprecated for two years, but that is not the case.

A s' ti nov tuki?

Still, it's a good that you created this PR, so that we show that deprecation is meant seriously and is coming. :)

janezd avatar Sep 12 '22 14:09 janezd

By the way, I think that failing the pyqt6 tests are caused by changes in orangewidgetbase (it started to fail after the release). I cannot reproduce it localy.

PrimozGodec avatar Sep 12 '22 14:09 PrimozGodec

I created a release of Image Analytics with colorpalette changes that users start to update to the new version. Geo does not need to be released -- only tests were fixed there. At Bioinformatic, fixes are merged, but it must be released before we merge this PR.

After Bioinformatics is released, I suggest waiting a bit before merging this PR so that more users update the addons (maybe we merge this PR after Orange 3.34 is released).

PrimozGodec avatar Oct 14 '22 12:10 PrimozGodec