orange3 icon indicating copy to clipboard operation
orange3 copied to clipboard

[NOMERGE][FIX] Fix tests cleanup

Open ales-erjavec opened this issue 2 years ago • 1 comments

Issue

After https://github.com/biolab/orange-widget-base/pull/204 the test will start failing/segfaulting.

Description of changes

Fix a call too commit in concurrent_example Fix OWWidget cleanup in tests.

Includes
  • [X] Code changes
  • [ ] Tests
  • [ ] Documentation

ales-erjavec avatar Jun 22 '22 09:06 ales-erjavec

Codecov Report

Merging #6044 (71b19ff) into master (263b782) will decrease coverage by 0.03%. The diff coverage is n/a.

:exclamation: Current head 71b19ff differs from pull request most recent head 1b7398d. Consider uploading reports for the commit 1b7398d to get more accurate results

@@            Coverage Diff             @@
##           master    #6044      +/-   ##
==========================================
- Coverage   86.62%   86.59%   -0.04%     
==========================================
  Files         315      315              
  Lines       67559    67317     -242     
==========================================
- Hits        58524    58294     -230     
+ Misses       9035     9023      -12     

codecov[bot] avatar Jun 22 '22 09:06 codecov[bot]

@ales-erjavec, is this now ready to be merged? Thanks.

markotoplak avatar Aug 29 '22 14:08 markotoplak

Yes

ales-erjavec avatar Aug 29 '22 14:08 ales-erjavec